Repository navigation
Make slicing slider a controlled component - #2084
Merged
Merged
Conversation
axelboc
force-pushed
the
controlled-slider
branch
from
October 15, 2026 12:34
03e3016 to
d5da67f
Compare
loichuder
approved these changes
Oct 15, 2026
axelboc
force-pushed
the
controlled-slider
branch
from
October 15, 2026 13:44
d5da67f to
2cf112b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Hibou diffraction image service, the URL holds the dimension mapping state, and this state can be changed dynamically from a parent frame (via
postMessage). I need the slider to move to the new value when this happens.While at it, I add props to change the default slicing stride, just in case.