Site dialog refactor - #355
Draft
gauthierm wants to merge 7 commits into
Draft
Conversation
gauthierm
marked this pull request as draft
August 10, 2026 18:03
gauthierm
commented
Aug 12, 2026
| parseInt(Dom.getStyle(this.container, 'marginTop')) + | ||
| parseInt(Dom.getStyle(this.container, 'marginBottom')); | ||
| let margin = | ||
| Math.parseInt(container_style.marginTop) + |
gauthierm
commented
Aug 12, 2026
| parseInt(Dom.getStyle(this.container, 'marginTop')) + | ||
| parseInt(Dom.getStyle(this.container, 'marginBottom')); | ||
| let margin = | ||
| Math.parseInt(container_style.marginTop) + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft to move site-dialog to DOM native APIs instead of using YUI2 utils. Ideally this entire file could be replaced with a standard
<dialog>element. The current work in progress strips out the deprecated YUI2 APIs.Testing Instructions (optional)
Add step-by-step instructions for testing the PR, if necessary.
Developer Checklist
Before requesting review for this PR, make sure the following tasks are
complete:
Reviewer Checklist
Before merging this PR, make sure the following tasks are complete: