fix(addon): support Classic Era and WoW Forever clients without GetSpecialization - #5
Open
thijsdaniels wants to merge 1 commit into
Open
thijsdaniels wants to merge 1 commit into
thijsdaniels wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Classic Era and the new WoW Forever Beta client (patch 1.60.1),
GetSpecialization()is not available and returnsnil. This causedDecktationContext.luato throw a Lua error on player login and specialization changes.Changes
GetPlayerSpec()fallback helper that inspects talent tabs usingGetNumTalentTabs()andGetTalentTabInfo()whenGetSpecializationisnil.EventFrame:SetScript("OnEvent", ...)calls that were overwriting event handler registrations.11506,16001,160000) toDecktationContext.toc.CHANGELOG.mdto version 1.1.1.Testing
1.60.1/_classic_beta_): no Lua errors on login or spec changes, and context dump correctly captures player class and talent specialization.