Skip to content

ensure we run in an venv - #336

Merged
gadfort merged 1 commit into
mainfrom
venv
Aug 28, 2026
Merged

ensure we run in an venv#336
gadfort merged 1 commit into
mainfrom
venv

Conversation

@gadfort

@gadfort gadfort commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Improved the design gallery test workflow by using an isolated Python environment during setup and execution.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 664ff2ff-7c34-46e1-bbff-4765a3e3d9d2

📥 Commits

Reviewing files that changed from the base of the PR and between c1a2b34 and 151b4ba.

📒 Files selected for processing (1)
  • .github/workflows/run-designs.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The design test workflow now creates and activates .venv before wheel installation. It reactivates .venv before running gallery designs with sc-gallery.

Changes

Design test environment

Layer / File(s) Summary
Virtual environment setup and gallery execution
.github/workflows/run-designs.yml
The installation step creates and activates .venv before installing wheels. The gallery execution step activates .venv before invoking sc-gallery.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 151b4

The workflow now runs design installation and execution inside a virtual environment, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: running gallery designs inside a Python virtual environment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch venv

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gadfort
gadfort merged commit 67bee50 into main Aug 28, 2026
44 checks passed
@gadfort
gadfort deleted the venv branch August 28, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant