Skip to content

feat: 实现预约会议高级管理功能 - #892

Open
ssfyn wants to merge 3 commits into
silenceper:v2from
ssfyn:v2
Open

feat: 实现预约会议高级管理功能#892
ssfyn wants to merge 3 commits into
silenceper:v2from
ssfyn:v2

Conversation

@ssfyn

@ssfyn ssfyn commented Aug 17, 2026

Copy link
Copy Markdown

实现预约会议高级管理功能

@ssfyn ssfyn changed the title 实现预约会议高级管理功能 feat: 实现预约会议高级管理功能 Aug 17, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4d2e363f4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread work/meeting/types.go Outdated
Comment thread work/meeting/meeting.go
Comment thread work/meeting/enroll.go Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f0087d893

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread work/meeting/types.go Outdated
Comment thread work/meeting/waitingroom.go

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea081a4650

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread work/meeting/types.go
Comment on lines +27 to +30
Password string `json:"password"`
EnableWaitingRoom *bool `json:"enable_waiting_room"`
AllowEnterBeforeHost *bool `json:"allow_enter_before_host"`
EnableEnterMute uint32 `json:"enable_enter_mute"`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve omission when partially updating settings

When MeetingUpdate supplies Settings to change only a field such as EnableEnroll, JSON encoding now also emits password:"", enable_waiting_room:null, allow_enter_before_host:null, and enable_enter_mute:0; present fields are therefore liable to clear the password, disable entry muting, or make the API reject the null booleans instead of leaving unrelated settings unchanged. Fresh evidence in the reviewed tree is that these fields now lack omitempty, while the value fields still cannot distinguish omission from an explicit empty/zero value; use optional representations that preserve that distinction.

Useful? React with 👍 / 👎.

Comment thread work/meeting/types.go

// Reminders 周期性会议配置
type Reminders struct {
IsRepeat uint32 `json:"is_repeat,omitempty"`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow recurrence to be disabled during updates

When an existing recurring meeting should be changed to non-recurring, callers must submit is_repeat: 0, but omitempty removes that value even when they pass a non-nil Reminders object. The update consequently cannot express the disable operation and leaves the existing recurrence in place; make this field optional independently of its numeric value.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant