feat: 实现预约会议高级管理功能 - #892
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4d2e363f4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f0087d893
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea081a4650
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Password string `json:"password"` | ||
| EnableWaitingRoom *bool `json:"enable_waiting_room"` | ||
| AllowEnterBeforeHost *bool `json:"allow_enter_before_host"` | ||
| EnableEnterMute uint32 `json:"enable_enter_mute"` |
There was a problem hiding this comment.
Preserve omission when partially updating settings
When MeetingUpdate supplies Settings to change only a field such as EnableEnroll, JSON encoding now also emits password:"", enable_waiting_room:null, allow_enter_before_host:null, and enable_enter_mute:0; present fields are therefore liable to clear the password, disable entry muting, or make the API reject the null booleans instead of leaving unrelated settings unchanged. Fresh evidence in the reviewed tree is that these fields now lack omitempty, while the value fields still cannot distinguish omission from an explicit empty/zero value; use optional representations that preserve that distinction.
Useful? React with 👍 / 👎.
|
|
||
| // Reminders 周期性会议配置 | ||
| type Reminders struct { | ||
| IsRepeat uint32 `json:"is_repeat,omitempty"` |
There was a problem hiding this comment.
Allow recurrence to be disabled during updates
When an existing recurring meeting should be changed to non-recurring, callers must submit is_repeat: 0, but omitempty removes that value even when they pass a non-nil Reminders object. The update consequently cannot express the disable operation and leaves the existing recurrence in place; make this field optional independently of its numeric value.
Useful? React with 👍 / 👎.
实现预约会议高级管理功能