Repository navigation
Sync TypeScript Server SDK docs #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ad181bf
d675a07
a6f2199
1deaaef
5d4b046
868e71c
063ea8d
244026a
d61c9e4
6de06a6
2e2c4c0
5c341a4
af750e4
590dec7
77ee23d
5599dd8
853d52d
766f843
35ec353
f99192a
5508bc5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -461,8 +461,8 @@ default. Set the | |||||||||||||
| URL to show your own image instead. | ||||||||||||||
|
|
||||||||||||||
| <Note> | ||||||||||||||
| The Python Server SDK accepts `visual_input` on a gate from version 3.7.1. The TypeScript Server SDK | ||||||||||||||
| doesn't accept it yet, so define video gates in SWML. | ||||||||||||||
| The Server SDKs accept `visual_input` on a gate from version 3.7.1: `visual_input` in Python and the | ||||||||||||||
| `visualInput` option in TypeScript. | ||||||||||||||
| </Note> | ||||||||||||||
|
|
||||||||||||||
|
Comment on lines
463
to
467
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd delete this Note. It states a minimum SDK version and names per-language options in guide prose, and the guides avoid both: say "the Server SDKs" and let the code tabs carry language names. Now that both SDKs accept
Suggested change
|
||||||||||||||
| ## Tune or turn off gates for a call | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule and the
@3.7.1pin go the opposite way from #908. #908 replaces "Pinned versions" with unpinned Server SDK installs and a no-minimum-version rule. Under this rule, every reference sync would also have to bump every guide. I'd drop this line and the pin changes on 105-106. The file also conflicts withmain, which moved the Browser pin to@signalwire/js@4.0.0-rc.5.