Repository navigation
fix: import default learner content with the Python API - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the learner-enabled Docker build:
python -m wn addis not a supported CLI command. Call the existingwn.add()Python API instead, keeping learner content enabled by default. Bump to v1.9.4 because v1.9.3's Docker publication failed before any image was pushed.Validation: 239 tests, lint, mypy and package build pass. Executed the exact corrected Docker import command against an isolated copy of the English WordNet database: the learner lexicon installed, 6,424 concepts received examples, and the original love/endearment definition was preserved while its reviewed examples and annotations became available.
Note
Low Risk
Single-line Docker build change plus version/changelog; no runtime API or auth changes.
Overview
v1.9.4 fixes the Docker image build that v1.9.3 introduced when learner content became the default.
The learner install step no longer runs
python -m wn add …(there is noaddCLI subcommand). It now imports the lexicon withwn.add('extensions/english-learner/rylo-en-learner.xml.gz', progress_handler=None), so default images can finish building and publish again.INSTALL_ENGLISH_LEARNERbehavior is unchanged.The changelog documents the fix;
__version__is bumped to 1.9.4.Reviewed by Cursor Bugbot for commit 8bcfb90. Bugbot is set up for automated code reviews on this repo. Configure here.