Skip to content

feat: add possessive apostrophe-s to English extras - #10

Merged
AmitMY merged 2 commits into
mainfrom
codex/possessive-s-extra
Oct 1, 2026
Merged

AmitMY merged 2 commits into
mainfrom
codex/possessive-s-extra

Conversation

@AmitMY

@AmitMY AmitMY commented Oct 1, 2026 •

Copy link
Copy Markdown

Add possessive 's to the English dictionary extras, with ’s as an alternative spelling. Its single meaning is a marker showing possession or association, illustrated by “women's health,” “John's coat,” and “This coat is John's.”

Docker loads the entry into omw-en:1.4 using the existing extension merger. The small extras file is separate from generated Wikidata data so regeneration preserves it.

Concept ID: omw-en-extra-possessive-s-y. Dictionary sign-link ID: extra-possessive-s-y.

Validation: 239 tests, lint, mypy and package build pass. An isolated import/API check confirms both spellings resolve to the same concept, all three examples are served, and re-import creates no duplicates.


Note

Low Risk
Adds one lexicon extension via the established merge path; no runtime or security-sensitive code changes.

Overview
Adds a manually maintained extensions/extras/ layer so small English gaps can ship without touching regenerated Wikidata output. The first extra is possessive 's / ’s as a particle (y), with one synset for possession/association and three examples (including standalone “This coat is John's.”). Stable IDs omw-en-extra-possessive-s-y / sign-link extra-possessive-s-y are documented and must not change.

Docker now copies extensions/extras/ and runs the existing merge_extension.py step so extras merge into omw-en:1.4 during image build, same as the Wikidata extensions.

Release v1.9.2 (wn.__version__ + CHANGELOG).

Reviewed by Cursor Bugbot for commit 84f64df. Bugbot is set up for automated code reviews on this repo. Configure here.

@AmitMY
AmitMY merged commit f2860f8 into main Oct 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant