Repository navigation
feat: add possessive apostrophe-s to English extras - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possessive
'sto the English dictionary extras, with’sas an alternative spelling. Its single meaning is a marker showing possession or association, illustrated by “women's health,” “John's coat,” and “This coat is John's.”Docker loads the entry into
omw-en:1.4using the existing extension merger. The small extras file is separate from generated Wikidata data so regeneration preserves it.Concept ID:
omw-en-extra-possessive-s-y. Dictionary sign-link ID:extra-possessive-s-y.Validation: 239 tests, lint, mypy and package build pass. An isolated import/API check confirms both spellings resolve to the same concept, all three examples are served, and re-import creates no duplicates.
Note
Low Risk
Adds one lexicon extension via the established merge path; no runtime or security-sensitive code changes.
Overview
Adds a manually maintained
extensions/extras/layer so small English gaps can ship without touching regenerated Wikidata output. The first extra is possessive's/’sas a particle (y), with one synset for possession/association and three examples (including standalone “This coat is John's.”). Stable IDsomw-en-extra-possessive-s-y/ sign-linkextra-possessive-s-yare documented and must not change.Docker now copies
extensions/extras/and runs the existingmerge_extension.pystep so extras merge intoomw-en:1.4during image build, same as the Wikidata extensions.Release v1.9.2 (
wn.__version__+ CHANGELOG).Reviewed by Cursor Bugbot for commit 84f64df. Bugbot is set up for automated code reviews on this repo. Configure here.