Repository navigation
Docs: cohesive with the code; benchmarks rerun on the current code - #94
Merged
Merged
Conversation
…r's input, dataset_tokenizer, overlapping chunks); history trimmed; new architecture figure Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
…he measured run halved the words per second) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
…h the full-length warmup) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
… baseline's padded vocabulary and fused cross entropy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An audit of the documentation against the code after #73–#93, so the repository reads as one: every README describes what the code does now, and every number comes from a run of the current code.
Docs
assets/architecture.pngregenerated from the paper's figure.welt_training/README.md:data.dataset_tokenizer, overlapping chunks of long documents, truncation with other pretokenizers; a leftover HF Trainer line removed.welt_training/experiments/pretrain/README.md: new.benchmarks/README.md: modality dropout shortened, a stale cache paragraph removed, packed patches moved into "What made it faster", steps overrides,flops.pyusage.Benchmarks rerun on the current code
benchmarks/README.md/tasks.csv(string repetition, OCR, letter count, English to Hebrew, SignWriting to text). Quality is the same or better (e.g. translation 0.531 bits per byte, chrF 47.6, was 0.547 / 45.4).welt_training/evaluate.py: warm up with full-length generations. The 2-word warmup left vLLM's decode kernels (Triton) to compile during the measured generation, which halved the words per second on a cold cache (string repetition 209 → 548 words/s, translation 459 → 910).🤖 Generated with Claude Code
https://claude.ai/code/session_015Xm62qoeaTunFSU5GYCQ1f
Note
Low Risk
Mostly documentation and benchmark CSV updates; the only code change is evaluation warmup timing, which affects reported throughput metrics not model behavior.
Overview
Aligns documentation with the current implementation and refreshes all benchmark numbers from reruns on today's code.
Docs update the main README and training README for words-segmentation/HF pretokenizers, native-size packed image patches, latent-as-BOS bytes decoding,
dataset_tokenizerfor token-id datasets, one-word-overlap document chunking, and a new pretrain experiment README. Benchmarks docs add packed patches to the speedups list, documentflops.pyusage, trim SignWriting/modality-dropout narrative (image encoder barely helps vs prior claims), and remove a stale dataset-cache note.Benchmarks:
tasks.csvand the tasks table get new ms/step, loss, and generation metrics (often faster steps and similar-or-better quality).welt-evaluatewarmup now uses the fullmax_generated_wordsinstead of 2-word warmup so Triton decode compile doesn't inflate measured words/s (e.g. string-repetition ~209→548, MT ~459→910).Reviewed by Cursor Bugbot for commit 4afd2a8. Bugbot is set up for automated code reviews on this repo. Configure here.