Repository navigation
Start BigQuery week buckets on Monday - #433
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery's bare
WEEKdate part starts on Sunday, so__weektime dimensions, week retention cohorts, andthis week-style relative dates compiled for BigQuery bucketed differently from every other dialect (DuckDB, Postgres, Snowflake, Spark all use Monday weeks). Both the Python and Rust compilers now emitWEEK(MONDAY)for BigQuery, matching what Ossie export already does. This changes week results for existing BigQuery queries.This also moves the lock to sqlglot/sqlglotc 30.23.0. sqlglotc 30.1.0 is no longer on the PyPI index, so the release workflow re-locks to 30.23 anyway; sqlglot 30.23 is what surfaced the week mismatch, since it now reads BigQuery
WEEKas Sunday-start when transpiling. The yardstick replay test helper handles 30.23 parsing DROP targets intotablesinstead ofthis.