Repository navigation
Keep filter menus and editors visible - #429
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2929ff2bd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Fixed height so the bar doesn't jump when pills replace the "No filters" text. | ||
| <div className="flex min-h-9 shrink-0 flex-wrap items-center gap-2 overflow-x-auto border-b border-line bg-surface px-3 py-2 md:h-9 md:flex-nowrap md:py-0"> | ||
| // Wrap crowded filters and keep their popovers above the stage without clipping them. | ||
| <div className="relative z-30 flex min-h-9 shrink-0 flex-wrap items-center gap-2 border-b border-line bg-surface px-3 py-1"> |
There was a problem hiding this comment.
When a model has enough active filters, especially on a narrow viewport, this shrink-0 wrapping row grows without any maximum height or scrolling. Because the surrounding shell is fixed to 100dvh and clips overflow, the strip can consume the entire stage and place later pills and the “+ Filter” control outside the visible area; popovers on the last visible rows can also receive a zero-pixel available height. Cap the strip and provide vertical scrolling or another bounded overflow strategy.
Useful? React with 👍 / 👎.
33c1548 to
3d21ba5
Compare
Fixes #418.
Let the filter strip wrap and keep its popovers above the page and row-preview drawer. Widen the menu and editor, wrap long values, and keep popovers within the viewport as filters wrap or the window resizes.
Adds browser regressions for desktop, narrow screens, crowded filters, and long-value selection, and refreshes the embedded UI bundles.