Repository navigation
Expose joined model dimensions in Explore and Pivot - #428
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ada768ef7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| contextColumn: ContextColumn; // leaderboard context column (E2) | ||
| comparison: ComparisonMode; // comparison window for deltas/overlay (E3) | ||
| comparisonRange?: DateRange; // explicit window when comparison === "custom" | ||
| joinedDims: string[]; // opt-in joined dimension leaderboards |
There was a problem hiding this comment.
When a user opts into a joined leaderboard without setting a date range or filter, Shell still considers the view clean because webapp/src/App.tsx only checks dateRange and filters when deciding whether to render Reset. Although the reducer now clears joinedDims on reset, the Reset button is unavailable in this common state, so the new selection cannot be reset through the standard control; include state.joinedDims.length in the dirty calculation.
Useful? React with 👍 / 👎.
aa6645b to
b958142
Compare
Expose reachable joined-model dimensions in the catalog, Pivot, and filter menu. Explore leaderboards are opt-in and persist in shared links, while Pivot retains valid joined deep links and distinguishes same-name fields across models.
Preserve field visibility and numeric/boolean filter types, and keep the primary model's date range when reopening joined filters. Include regression coverage and rebuilt embedded UI bundles.
Fixes #420.