Repository navigation
Expose semantic models through standard database catalogs - #407
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63fd11e642
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case LogicalTypeId::TINYINT: bits = 8; break; | ||
| case LogicalTypeId::SMALLINT: bits = 16; break; | ||
| case LogicalTypeId::INTEGER: bits = 32; break; | ||
| case LogicalTypeId::BIGINT: bits = 64; break; | ||
| case LogicalTypeId::HUGEINT: bits = 128; break; | ||
| case LogicalTypeId::FLOAT: bits = 24; break; | ||
| case LogicalTypeId::DOUBLE: bits = 53; break; |
There was a problem hiding this comment.
When a semantic dimension binds to UTINYINT, USMALLINT, UINTEGER, UBIGINT, or UHUGEINT, this switch falls through without setting precision, radix, or scale. Consequently, information_schema.columns exposes NULL numeric metadata for these virtual columns even though the corresponding physical DuckDB columns report bit precision, radix 2, and scale 0; this also makes the newly added unsigned cases in test_standard_catalog_numeric_metadata_matches_host fail.
Useful? React with 👍 / 👎.
1 participant
Expose loaded semantic models as virtual views in the current database's
semanticschema so SQL clients can discover dimensions and metrics throughinformation_schemaandpg_catalog, then query them with ordinary qualified SELECTs. Bind field types against the source, preserve physical relation precedence, and respect transaction visibility without creating persistent mirror views.Package immutable DuckDB 1.5.6 extension releases for Linux and macOS on AMD64 and ARM64, with checksums and verification that the release tag identifies the built commit. Make the optional ADBC regression tests skip correctly when the driver manager is absent.