-
Notifications
You must be signed in to change notification settings - Fork 41
docs: document --flutter-version=fvm and =system #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
a4a33a0
02ddf2a
20893b9
9c5f727
c6e0f9e
df19b21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,7 @@ words: | |
| - ffigen | ||
| - fintech | ||
| - frontmatter | ||
| - fvmrc | ||
| - gallego | ||
| - gles | ||
| - graphql | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,6 +106,32 @@ always be built with the version of Flutter used by the release. | |
|
|
||
| ::: | ||
|
|
||
| ### Match the Flutter version you already use | ||
|
|
||
| If you manage Flutter with [fvm](https://fvm.app), or you just want Shorebird to | ||
| follow the `flutter` on your `PATH`, `--flutter-version` accepts two aliases so | ||
| you don't have to repeat the version number: | ||
|
|
||
| ```sh | ||
| # Use the version fvm resolves for this project (from its .fvmrc). | ||
| shorebird release android --flutter-version=fvm | ||
|
|
||
| # Use the version reported by the `flutter` on your PATH. | ||
| shorebird release android --flutter-version=system | ||
| ``` | ||
|
|
||
| Shorebird asks that Flutter which version it is, then builds with Shorebird's | ||
| fork of Flutter at the same version. It does not build with your fvm or system | ||
| Flutter install, so the usual rules still apply: the version has to be one | ||
| Shorebird supports, and patches are built with the version used by the release. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: the Fix: trim the tail so the sentence ends on the point unique to this section: Flutter install, so the usual rules still apply: the version has to be one
Shorebird supports. |
||
|
|
||
| :::note | ||
|
|
||
| `--flutter-version=fvm` requires `fvm` on your `PATH`, and runs | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This describes the fallback, not the normal path, and it leaves out the part users will actually notice. What
Why it matters: step 3 is the expensive path. From the implementation comment, "That can install Flutter first, which is slow and prints nothing while it runs, so we say what we're waiting on." The CLI prints a progress message specifically because of this. Someone whose Fix: :::note
`--flutter-version=fvm` requires `fvm` on your `PATH`. Shorebird asks fvm for the
version your project pins, which it reads from `.fvmrc` without running Flutter.
If your project pins a channel (like `stable`) or a fork instead of a version
number, Shorebird has to ask that Flutter which version it is, which means fvm
may download and install it first. That can take several minutes the first time.
::: |
||
| `fvm flutter --version` from your project directory to resolve the version. | ||
|
|
||
| ::: | ||
|
|
||
| ### Flutter version notes | ||
|
|
||
| To help you avoid hidden pitfalls, Shorebird maintains version notes on Flutter | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, and only relevant once this is unblocked: it may be worth a sentence noting that these aliases need a CLI that has them.
Everything else on this page works on any recent CLI, so a reader on v1.6.122 who hits
Version fvm not foundhas no way to tell from the page that their CLI is simply too old. A short "requires Shorebird vX.Y.Z or later" line, filled in once the release ships, would close that gap. The version table above sets the precedent for that style.