Repository navigation
Return debit replay reasons before authorization - #1078
Merged
Merged
Conversation
boufni95
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return the existing debit GFY-6 replay reasons before authorization, matching the behavior of the authorized payment path and CLINK spec PR #19.
Previously, a new/unapproved requestor presenting an already-paid or already-failed invoice reached
withExclusiveInvoiceCheck, but only the in-progress error was translated into a CLINK error. Paid/failed errors escaped as ordinary exceptions and the transport returned generic code 2 (Temporary Failure).The pre-authorization path now returns:
reason: "invoice_already_paid"for paid invoices.reason: "invoice_already_failed"for failed invoices.reason: "invoice_in_progress"for pending invoices, unchanged.No approval prompt, notification, new k1 hold, or payment is created for these replays. The existing auth-reservation cleanup remains in place.
Verification
npm run build: passed.Scope
Branched from
dash2and targetsdash2. Contains only this error-mapping fix and its regression test, not the separate offer-quantity work. No SDK dependency, lockfile, payout-policy, or release changes.Spec: shocknet/CLINK#19