Skip to content

Make Manage callback URLs optional - #37

Open
shocknet-justin wants to merge 1 commit into
stagingfrom
optional-manage-callback
Open

shocknet-justin wants to merge 1 commit into
stagingfrom
optional-manage-callback

Conversation

@shocknet-justin

Copy link
Copy Markdown
Member

Behavior

  • callback_url is optional and nullable in Manage offer fields and returned offer data.
  • Create builders omit an unspecified callback instead of inventing an empty string.
  • Update builders preserve omission versus explicit null, empty string, or URL.
  • Omission on create means no callback; omission on update preserves it; null or an empty string clears it.
  • Label, price_sats, and payer_data remain required on the wire. Updates still require offer.id; an account pointer alone is not sufficient.

Verification

  • npm test: 168 passed, including public type checks and signed/encrypted wire tests.
  • Offline compatibility: 4 passed against SDK 1.7.4.

Coordination

Based on staging after the merge of #35. Pub storage and migration support are in shocknet/Lightning.Pub#1077; the protocol wording is in shocknet/CLINK#18. Pub stores absent offer callbacks as SQL NULL and keeps its SDK dependency unchanged until release. No version or dependency changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant