Repository navigation
1.8 - #32
Open
shocknet-justin wants to merge 20 commits into
Open
1.8#32shocknet-justin wants to merge 20 commits into
shocknet-justin wants to merge 20 commits into
Conversation
…ion 1. Legacy events with no clink_version tag still count as v1. k1 is only valid on a direct payment request. Co-authored-by: Cursor <cursoragent@cursor.com>
Callers that read err.message were getting undefined; 1.8.0 matches the rest of sendRequest. Co-authored-by: Cursor <cursoragent@cursor.com>
…1.8.0 - Restore typescript/rimraf to devDependencies and regenerate the lockfile from staging, which drops the downgraded, vulnerable glob/minimatch. - Drop the @scure/base override; it only affected local installs. - Use pool.subscribe (single filter), which has the same signature in nostr-tools 2.15 and 2.25, so caller-supplied older pools keep working. - Make all AbstractSimplePool imports type-only and point nenroll at the same abstract-pool path as the rest. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
update tools
GFY 6 reason tokens and CLINK v1-only replies
Reject request timeouts as Error
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
A one-byte payload made the length undefined, and slice(NaN) returned the same buffer, so decode looped forever. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Nov 6, 2026
Harden 1.8 encoding, request validation, and relay handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included in 1.8
Error.nostr-tools/@scureupdates and printable-ASCII validation for exportednip19.decode.main.Offer Payer Data and Quantity
Aligned with shocknet/CLINK#18:
NofferPayerDataand allow numericquantityinNofferData.quantityto be a positive safe integer; all other payer-data values are strings.payer_data?: string[]onNofferErrorfor offer code-6 discovery and explicit retry.Verification
npm test: 67 passed, 0 failed, including compile-time public type checks, invalid-value cases, and signed/encrypted discovery and retry.Release Coordination
Pub support is on https://github.com/shocknet/Lightning.Pub/tree/offer-payer-data-quantity from
dash2. Its SDK dependency is intentionally unchanged pending the 1.8 release and must be bumped ondash2before the Pub release merge. This update does not publish, tag, or merge 1.8.