Skip to content

1.8 - #32

Open
shocknet-justin wants to merge 20 commits into
mainfrom
staging
Open

1.8#32
shocknet-justin wants to merge 20 commits into
mainfrom
staging

Conversation

@shocknet-justin

@shocknet-justin shocknet-justin commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Included in 1.8

  • Debit GFY-6 reason tokens and response metadata, stricter debit shape validation, and request timeouts that reject with Error.
  • Legacy version-tag acceptance while rejecting explicitly unsupported or mixed versions, and beacon d-tag matching across multiple tags.
  • nostr-tools / @scure updates and printable-ASCII validation for exported nip19.decode.
  • The 1.7.4 TLV length guard and regression test are retained after merging main.

Offer Payer Data and Quantity

Aligned with shocknet/CLINK#18:

  • Export NofferPayerData and allow numeric quantity in NofferData.
  • Require quantity to be a positive safe integer; all other payer-data values are strings.
  • Expose payer_data?: string[] on NofferError for offer code-6 discovery and explicit retry.
  • Validate outgoing offers before encryption or relay contact; preserve undefined optional-field behavior.
  • Document host-side unit-price resolution for fixed, variable, and spontaneous categories. Quantity only multiplies when required by the host; wallets verify the final invoice total.

Verification

npm test: 67 passed, 0 failed, including compile-time public type checks, invalid-value cases, and signed/encrypted discovery and retry.

Release Coordination

Pub support is on https://github.com/shocknet/Lightning.Pub/tree/offer-payer-data-quantity from dash2. Its SDK dependency is intentionally unchanged pending the 1.8 release and must be bumped on dash2 before the Pub release merge. This update does not publish, tag, or merge 1.8.

shocknet-justin and others added 13 commits August 31, 2026 01:33
…ion 1.

Legacy events with no clink_version tag still count as v1. k1 is only valid on a direct payment request.

Co-authored-by: Cursor <cursoragent@cursor.com>
Callers that read err.message were getting undefined; 1.8.0 matches the rest of sendRequest.

Co-authored-by: Cursor <cursoragent@cursor.com>
…1.8.0

- Restore typescript/rimraf to devDependencies and regenerate the lockfile
  from staging, which drops the downgraded, vulnerable glob/minimatch.
- Drop the @scure/base override; it only affected local installs.
- Use pool.subscribe (single filter), which has the same signature in
  nostr-tools 2.15 and 2.25, so caller-supplied older pools keep working.
- Make all AbstractSimplePool imports type-only and point nenroll at the
  same abstract-pool path as the rest.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
GFY 6 reason tokens and CLINK v1-only replies
@socket-security

socket-security Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​scure/​base@​1.1.1 ⏵ 2.4.010010010082 +1100
Updatednostr-tools@​2.15.1 ⏵ 2.25.29910010091 -1100

View full report

shocknet-justin and others added 3 commits November 5, 2026 16:12
A one-byte payload made the length undefined, and slice(NaN) returned the same buffer, so decode looped forever.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants