Skip to content

Migrate media packages into standalone repository - #1

Merged
hariria merged 3 commits into
mainfrom
hariria/move-media-kit-packages
Aug 26, 2026
Merged

hariria merged 3 commits into
mainfrom
hariria/move-media-kit-packages

Conversation

@hariria

@hariria hariria commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • migrate @shelby-protocol/media-prepare and @shelby-protocol/player from shelby/shelby
  • initialize a pnpm Turborepo containing only those two packages
  • carry over the Shelby Biome configuration and dependency lock versions
  • add CI and Changesets-based npm release automation
  • make previously implicit monorepo dependencies and test boundaries explicit

Validation

  • pnpm install --frozen-lockfile
  • pnpm lint
  • pnpm build
  • pnpm test (16 tests pass)

Related removal

After this PR merges, shelby/shelby#1995 removes the original package copies and their monorepo integrations.

Operational follow-up

Before publishing from this repository, update the npm trusted-publisher configuration for both packages to point at shelby/media-kit and its npm-release workflow.


Note

Medium Risk
Large repository split with new npm publish automation; incorrect trusted-publisher or Changesets config could affect public package releases, though runtime behavior is largely a move rather than new product logic.

Overview
Bootstraps the Shelby Media Kit repository by moving @shelby-protocol/media-prepare and @shelby-protocol/player out of shelby/shelby into a dedicated pnpm + Turborepo workspace with shared Biome lint/format and Node 22 / pnpm 10 tool versions.

Adds release and quality automation: GitHub Actions CI runs pnpm lint, build, and test on PRs and main; a Changesets-driven NPM Release workflow on main opens version PRs and publishes via pnpm release (build + changeset publish) with OIDC-oriented npm setup.

Package layout is unchanged in spirit but made self-contained: media-prepare keeps core / node / browser exports (CMAF plan builder, FFmpeg transcoding, Shaka or FFmpeg packaging on Node, FFmpeg.wasm on browser) with Vitest split into default, browser (Playwright), and local FFmpeg integration configs. Player remains a React + Shaka + media-chrome component library with Storybook, Tailwind theme CSS exports, and new unit tests for controls visibility and Shaka ref wiring.

Root README documents the two packages and dev commands; follow-up noted in the PR description is repointing npm trusted publishers to this repo before publishing.

Reviewed by Cursor Bugbot for commit b26e5b3. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 5 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d424468. Configure here.

@hariria
hariria requested a review from 0xmaayan August 26, 2026 00:46
@hariria hariria self-assigned this Aug 26, 2026
@hariria
hariria merged commit 23340ad into main Aug 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants