Repository navigation
chore(deps): lock file maintenance - #355
renovate[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
I can't judge this change, so there is no approval. Every read of the PR head in this run came back filtered by the integrity policy as below the level I'm allowed to see: the diff, the changed-file list, the head commit. I never saw a line of the 561 added. An approval from me would merge this with no human looking, and I won't approve a diff I haven't read.
What I did verify, from sources the filter allowed:
- One commit, one changed file, +561/-550, on top of current main. Every signal says that file is
pnpm-lock.yaml: lock file maintenance rewrites the lockfile only, the PR body says "All locks refreshed", and the churn fits the 5708-line lockfile rather than any manifest. That is inference, not a read of the file list. - Nothing reached consumers. No manifest changed, the required Protected paths check passed on the head, and every CI job ran
pnpm install --frozen-lockfilegreen, so the refreshed lockfile satisfies the unchanged manifests. - The
renovate.jsonholds hold by construction.@types/nodeis^24.19.2in the manifest,tools/api-docspinstypescript6.0.3exactly, andtypescript-6aliases6.0.3. A green frozen install cannot lock a version outside those ranges. - CI is green on the head across the matrix, and
minimumReleaseAgeStrictmakes the install itself prove every locked package is at least a day old. - What no gate covered: which packages the refresh moved, and whether it added a package the base lockfile didn't have. That is the one check in the agent contract that needs the diff, and I couldn't do it.
I have no tool to add needs-maintainer, so this comment is the stop. Skim the diff and merge by hand, or fix the reviewer's read path so the next agent:deps review can read what it approves. Nothing here says the PR is wrong; it says I couldn't read it.
Generated by Agent PR review for #355 · claude · glm53 · ~27 AIC · ⌖ ~5 AIC · ⊞ 15.2K
09a4f8c to
56622d4
Compare
There was a problem hiding this comment.
Still no verdict, and for the same reason as my review on the old head: the integrity policy filtered every read of this PR's content. This run it blocked the file list, the diff, the head commit detail, the head tree, and a single-file fetch of pnpm-lock.yaml at refs/pull/355/head. That earlier review carried no findings, only this blocker, and it is unchanged on head 56622d4. I have not seen a line of the diff, this approval would merge the PR with no human looking, so I am not giving it.
What the allowed reads did pin down:
- No manifest changed. One file changed, and every CI job that builds anything installs with
pnpm install --frozen-lockfilegreen, which fails when an editedpackage.jsonno longer matches the lockfile. So therenovate.jsonholds hold by construction: the unchanged manifests keep@types/nodeat^24.19.2,tools/api-docsontypescript6.0.3, and thetypescript-6alias at6.0.3. - No protected path changed.
Protected pathscompared the merge base to the head and passed, so.github/,scripts/release*,scripts/sync-version.mjsandtsdown.config.tsare untouched, and rootpackage.jsonmoved at most insidedevDependencies, which the frozen install already rules out. - The one changed file is therefore
pnpm-lock.yamlby elimination: a single commit from Renovate's lock-file-maintenance branch, +561/-550 against a 5708-line base lockfile. Any other reading needs Renovate to have written a file its maintenance flow does not write. - A new install-script package would stay inert.
pnpm-workspace.yamlallowBuildsadmits only@parcel/watcherandesbuild, and if the lockfile is the changed file that list did not move; pnpm skips builds for everything else. But noticing such a package in the refresh is the one check the pipeline assigns to this review rather than to CI, and I could not do it.
Everything above is also enforced by gates that run without me. The one check only a diff-reading reviewer performs is the one the filter blocked. Your options are as before: skim the diff and merge by hand, your own approval merges it, or restore the reviewer's read path so the next Monday refresh gets judged on its content. Nothing I could read says the PR is wrong.
Generated by Agent PR review for #355 · claude · glm53 · ~24 AIC · ⌖ ~6 AIC · ⊞ 16K
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.