Repository navigation
feat: accept direct command arguments after separator - #949
Open
Huzaifa-Asif wants to merge 4 commits into
Open
Huzaifa-Asif wants to merge 4 commits into
Huzaifa-Asif wants to merge 4 commits into
Conversation
Huzaifa-Asif
marked this pull request as ready for review
October 4, 2026 06:38
…nd-arguments # Conflicts: # README.md # src/cli.rs # src/options.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--as one benchmark commandstd::process::CommandUnlike the closed, unmerged #880, this does not join arguments into a command expression for execution.
shell_words::joinis used only to produce the human-readable benchmark name; the executed argv remains structured.The branch now includes upstream
masterate4a3213; the conflict resolution preserves the new metrics and default-shell CLI behavior while retaining direct-argument parameter detection. The regression test was adapted to the upstream removal of--time-unitwithout weakening its quoted-argument-boundary assertion.Verification
cargo fmt -- --check— passed on exact head398f6a8cargo clippy --locked --all-targets -- -D warnings— passed with Rust 1.99.0cargo test --locked— 124 tests passed with Rust 1.99.0 (52 unit, 18 execution-order, 54 integration)git diff --check— passedFixes #802
AI assistance disclosure
OpenAI Codex assisted with command-path research, implementation, regression tests, conflict resolution, verification, and drafting this description.