Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
CLICOLOR_FORCE=trueadds ansi escapes to clap's error output. the zero-runs integration test then fails because it expects plain text. fixes #1001.what changed
CLICOLOR_FORCEfrom the environment of integration test commands.scope
blast radius
all integration tests use this helper, so they no longer inherit this one terminal preference from the machine that runs them.
verification
CLICOLOR_FORCE=trueandNO_COLORunset. the integration suite passed all 58 tests after the change.cargo fmt -- --check, and clippy with warnings denied.CLICOLOR_FORCE=true.