Repository navigation
fix: pass a format string to logging.info in dataframe_empty_handler - #292
Conversation
|
Thanks a lot for the fix and for adding a regression test — this cleanly closes out #291, and the test nicely captures the original TypeError that used to get swallowed by logging's internal error handling. 🙏 ruff check --config pyproject.toml .
ruff format --check --config pyproject.toml .locally and push a fix for whatever it flags? If ruff format --check is the one complaining, ruff format --config pyproject.toml . should auto-fix it. Let us know if the failure doesn't reproduce locally (Ruff version drift between local and CI is always a possibility since it isn't pinned in the workflow) — happy to help dig into it further. Thanks again for the contribution! |
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
6480e70 to
4171ca1
Compare
|
The lint failure was ruff 0.16 reformatting code blocks in the markdown files (README, CONTRIBUTING, tests/README, copilot-instructions), not the two files in this PR. Master already has those reformatted, so I rebased onto it and |
|
LGTM, Thanks for the fix. |
#291
logging.info(args, kwargs) passes the wrapper's args tuple as the message and kwargs as the single positional arg instead of a format string, so formatting the record can raise TypeError: not all arguments converted during string formatting from inside the logging module itself. Every caught exception in a decorated function ends up printing a confusing second traceback. Switched to logging.info("args=%r kwargs=%r", args, kwargs).