Fix non-manifold edges because end point is close to but not exactly … - #250
Open
North101 wants to merge 1 commit into
Open
Fix non-manifold edges because end point is close to but not exactly …#250North101 wants to merge 1 commit into
North101 wants to merge 1 commit into
Conversation
…equal to first point
Author
|
Fixes #247 though a better fix might be to just rewrite the last point |
Author
Still get issues because of this kind of rounding error but thats to be expected and I guess I just need to use a script to fix it.
The library that converts paths to absolutes adds lots of floating point drift which was probably causing this issue at a very imperceptible scale
|
Author
|
Opened this PR sgenoud/replicad-decorate#3 as either an alternative or in addition to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
.closeis called it checks if the endpoint is the same as the last point, but if the last point isn't exactly equal to the first point it can create non-manifold edges in the stl. This PR fixes this by replacing any end point that passessamePointwith the first point