Repository navigation
friglet-ipc, blindbit-cli: narrow the interface, fix comments (SNB-676) - #55
Closed
setavenger wants to merge 1 commit into
Closed
setavenger wants to merge 1 commit into
setavenger wants to merge 1 commit into
Conversation
friglet-ipc items only its own module uses are private now:
write_message, read_message, SpDescriptor::scan_pubkey,
descriptor_checksum, the log-file constants and RotatingLog::with_limit.
No other crate in the workspace uses them, and neither does friglet-ui
(it uses Request/Response/StatusInfo, Client, listen, accept,
read_config_toml and DaemonConfig).
Comments: no frigletctl tool exists; state_file documents the per-wallet
file name; OkWithNote's example is what the daemon sends today;
oracle_connected describes the background poll, not a cache TTL. The
default oracle_url uses the same constant as hosted_oracle_url("bitcoin")
instead of repeating the URL. The roundtrip test sets scan_health twice;
blindbit-cli has four comments that restate the next line.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 3, 2026
Owner
Author
|
Merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the friglet cleanup (SNB-661). Implements SNB-676. +27 −24 lines (doc comments grew); no behaviour change, no wire change.
What changed
write_message,read_message(lib.rs),SpDescriptor::scan_pubkey,descriptor_checksum(descriptor.rs),MAX_LOG_BYTES,KEPT_ROTATIONS,DAEMON_LOG_NAME,TRAY_LOG_NAME,RotatingLog::with_limit(logfile.rs). No other crate in this workspace uses them. friglet-ui (blindbit-node-apps) depends on friglet-ipc and uses onlyRequest,Response,StatusInfo,Client,listen,accept,read_config_tomlandDaemonConfig(checked by grep; its ownscan_pubkeyis on itsWalletKeys).frigletctltool that does not exist.state_filenow says that the default path is keyed per wallet (scanner_state-<network>-<wallet id>.json) and that an explicit path is used as is.OkWithNote's example ("which changed settings need a daemon restart") is replaced by what the daemon sends today.oracle_connecteddescribed a "cache TTL"; it reflects the background poll within the last 30 s.oracle_urlusesnetwork::MAINNET_ORACLE_URL, the same constanthosted_oracle_url("bitcoin")returns, instead of repeating the literal (same value).tests/roundtrip.rssetscan_health: Default::default()next to..Default::default().Verification
cargo check --workspace --all-targets --all-features: 0 warningscargo clippy --no-deps -p friglet -p friglet-ipc -p friglet-tray --all-targets -- -D warnings: cleancargo fmt -p friglet -p friglet-ipc -p friglet-tray -- --check: cleancargo test --workspace: 254 passed, 1 ignored, 0 failed (same as base)Not touched:
friglet-ipc/Cargo.toml.