Repository navigation
ci: restore gating workflows (SNB-533) - #62
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a19b720a-d439-4725-917e-b7959b8eaf83) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oracle's test step previously ignored failures, and obsolete action runtimes prevented its workflows from running reliably. This change makes tests gate pull requests to
master, removes deleted-branch triggers, and restores a single Docker image publication per release tag.SNB-533
Changes:
continue-on-errorand deletedv2triggers.devDocker branch path, unused commit-hash action, duplicate publication, and invalid build argument.Validation:
go test ./...passed before changes.go test -v ./...exit 1; the temporary test was removed.go build ./...,go test -v ./..., workflowactionlint, andgit diff --checkpassed.The deliberate failure was exercised locally, not in a GitHub-hosted PR run. Docker publication was not executed because it would publish release images.
Note
Medium Risk
Test failures will now fail CI on master PRs, and Docker images publish only on version tags—no more automatic dev-branch images.
Overview
Restores CI gating so
go test -v ./...failures block merges onmaster, and narrows when workflows run after obsolete branch paths were removed.The Build Test workflow now triggers only on
master(dropsv2), bumpsactions/cacheto v6, and removescontinue-on-erroron the test step so PRs are no longer green when tests fail.The Docker workflow now runs only on
v*release tags—no pushes todev—with a single build/push step taggedsetavenger/blindbit-oracle:${{ github.ref_name }}. It drops the dev-SHA image path, the commit-hash helper, duplicate conditional jobs, and the invalidbuild-args, and upgrades checkout and Docker-related actions to current major versions.Reviewed by Cursor Bugbot for commit 9f1c2ab. Configure here.