Skip to content

ci: restore gating workflows (SNB-533) - #62

Merged
setavenger merged 1 commit into
integrationfrom
agent/snb-533-gate-ci
Sep 21, 2026
Merged

setavenger merged 1 commit into
integrationfrom
agent/snb-533-gate-ci

Conversation

@setavenger

@setavenger setavenger commented Sep 20, 2026 •

Copy link
Copy Markdown
Owner

The oracle's test step previously ignored failures, and obsolete action runtimes prevented its workflows from running reliably. This change makes tests gate pull requests to master, removes deleted-branch triggers, and restores a single Docker image publication per release tag.

SNB-533

Changes:

  • Remove test continue-on-error and deleted v2 triggers.
  • Remove the deleted dev Docker branch path, unused commit-hash action, duplicate publication, and invalid build argument.
  • Update obsolete action runtimes in the two workflows.

Validation:

  • Baseline go test ./... passed before changes.
  • A temporary deliberately failing test made the exact workflow command go test -v ./... exit 1; the temporary test was removed.
  • Final go build ./..., go test -v ./..., workflow actionlint, and git diff --check passed.
  • Independent review found obsolete action runtimes; after correction, rereview found no remaining issues.

The deliberate failure was exercised locally, not in a GitHub-hosted PR run. Docker publication was not executed because it would publish release images.


Note

Medium Risk
Test failures will now fail CI on master PRs, and Docker images publish only on version tags—no more automatic dev-branch images.

Overview
Restores CI gating so go test -v ./... failures block merges on master, and narrows when workflows run after obsolete branch paths were removed.

The Build Test workflow now triggers only on master (drops v2), bumps actions/cache to v6, and removes continue-on-error on the test step so PRs are no longer green when tests fail.

The Docker workflow now runs only on v* release tags—no pushes to dev—with a single build/push step tagged setavenger/blindbit-oracle:${{ github.ref_name }}. It drops the dev-SHA image path, the commit-hash helper, duplicate conditional jobs, and the invalid build-args, and upgrades checkout and Docker-related actions to current major versions.

Reviewed by Cursor Bugbot for commit 9f1c2ab. Configure here.

@cursor

cursor Bot commented Sep 20, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_a19b720a-d439-4725-917e-b7959b8eaf83)

@setavenger
setavenger changed the base branch from master to integration September 21, 2026 20:40
@setavenger
setavenger merged commit eef28d3 into integration Sep 21, 2026
2 checks passed
@setavenger
setavenger deleted the agent/snb-533-gate-ci branch September 21, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant