fix: Replace super_clipboard to resolve 16kb page memory crashes on Android#20
Open
abdulmominsakib wants to merge 1 commit into
Open
fix: Replace super_clipboard to resolve 16kb page memory crashes on Android#20abdulmominsakib wants to merge 1 commit into
abdulmominsakib wants to merge 1 commit into
Conversation
Author
|
@vlidholt can you take a look 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem: Currently, this package relies on super_clipboard to provide syntax-highlighted (HTML) copying functionality. However, super_clipboard depends on super_native_extensions, which currently contains a critical bug: it does not support 16kb page memory sizes (super_native_extensions#560).
Because newer Android devices (like the Pixel 8 series on Android 15+) are transitioning to 16kb page sizes, applications importing this package are experiencing native crashes that are completely out of their control.
Solution: This PR swaps out super_clipboard for the clipboard package. Recent updates to the clipboard package introduced native support for Rich Text (HTML) copying, which means we no longer need the heavy native dependencies that super_clipboard brings.
Changes:
Removed super_clipboard from pubspec.yaml
Added clipboard: ^3.0.14 to pubspec.yaml
Refactored _CopyAction.invoke in code_editor.dart to use the cleaner FlutterClipboard.copyRichText API.
Impact: