Code challenge submission#378
Open
6in4 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Nokogiri for HTML parsing and RSpec for testing.
Run
bundle exec rspecfor tests.Run
ruby lib/page.rb <html file>to output JSON.I've added three additional HTML files: Michelangelo sculptures, Picasso paintings, and Monet paintings.
Key assumptions
scrapemethod is a single public entrypoint by designscrape_method and merging the output therekc:/visual_art/visual_artist:works) - the scope limitation is intentionalexpected-array.jsonreturns an object containing{ "artworks": [] }wp-grid-{view,tile})ScraperErrorclass exists (could be split further, but for the sake of this exercise, I haven't done this) - throw a specific error, with reasoning as to why it was thrownIn short, my scraping philosophy is: fail fast, fail loudly, and be observable.
Full transparency: this was my first time writing Ruby from scratch, and while I tried to write idiomatic Ruby, there may be some instances where the code is non-idiomatic. This branch contains cleaner history, but my full workflow is in the
prototypebranch (browser console -> Cheerio -> Nokogiri).