Repository navigation
Only add names to draft registers - #293
Merged
Merged
Conversation
vangberg
commented
Jun 29, 2026
| has_rich_text(:abstract) | ||
| has_rich_text(:submitter_authorship_explanation) | ||
|
|
||
| scope :drafts, -> { where(validated: false, notified: false, submitted: false) } |
Contributor
Author
There was a problem hiding this comment.
One question is, if we want to go down the route of having these scopes, should we straight away implement the other state scopes (#notified etc) and use them?
lmrodriguezr
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216
Bug
The existing code in
RegistersController#newhas this guard:This almost works, but includes registers that follow the path of going straight from
drafttonotified. They have bothsubmitted=falseandvalidated=falsebecause they never went through that path.Change
This pull request does two things:
Name#add_to_registerto ensure that registers are indraft.draftsscope toRegister, which checkswhere(validated: false, notified: false, submitted: false), and use that to select registers to show to the user in the dropdown.No changes to the UI in this pull request, except that non-draft register lists are not in the dropdown.
Alternative UI
I have a local change with a quick attempt at the table based interface we discussed. Not sure if we want to continue with that, I think the dropdown probably works well as long as you don't show the wrong registers. Thoughts?