Skip to content

Send mails in after_create_commit hook #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmrodriguezr merged 1 commit into from
Jun 29, 2026
Merged

Send mails in after_create_commit hook #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/models/contact.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ class Contact < ApplicationRecord

has_rich_text(:message)

after_create(:send_message)
# Enqueue email only after commit to avoid timing issues where the job runs
# before the contact creation is visible outside the transaction.
after_create_commit(:send_message)

def default_message
<<~MSG
Expand Down
4 changes: 3 additions & 1 deletion app/models/notification.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ class Notification < ApplicationRecord
belongs_to :notifiable, polymorphic: true
belongs_to :linkeable, polymorphic: true, optional: true

after_create(:send_email_notification)
# Enqueue email only after commit to avoid timing issues where the job runs
# before the notification creation is visible outside the transaction.
after_create_commit(:send_email_notification)
after_save(:broadcast_notification_count)
after_create(:broadcast_web_notification)

Expand Down
Loading