Repository navigation
Add Áureo with an exact-atlas maintainer exception - #26
Merged
Merged
Conversation
Preserve the original submitted artwork and metadata while completing pet 008's package, previews, attribution, catalogue card and installer. Retain the strict chroma findings and left-look limitation in public QA and presentation. Pin the maintainer exception to this atlas and evidence, keep other pets' strict requirements intact, and test that changed assets, erased findings, copied exceptions and missing or corrupt package data are rejected.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (6)
📒 Files selected for processing (16)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change publishes Áureo as pet 008 and adds a maintainer exception for its pinned atlas and evidence. The validator checks the exception and its required disclosures while retaining strict validation for other pets. ChangesÁureo catalogue entry and exception
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~40 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The exception remains limited to the documented Áureo atlas, and no identified issue blocks merging after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Áureo as pet 008, preserving the contributor's original spritesheet and manifest byte-for-byte. The catalogue presents it as reviewed with known limitations: the original left-look pose faces right, and strict QA retains eleven flagged chroma-edge pixels across eight cells. Related to #24.
Scope and reason
The maintainer accepted the original design, including its emblem and jumping choreography. This change completes the package and catalogue integration without redesigning the pet or asking the contributor to perform repository maintenance.
An explicit exception applies only to
aureo, catalogue 008, sprite v2, atlas SHA-256614dabf05306723f15415b2ae7ecae47ba4e9437ffd5083a437303f763e67098. The validator also pins the independent strict report, requires the exception record and disclosure, and retainsok: false, eight chroma cell errors and the failed left-cardinal result. All other pets retain the existing strict requirements; global chroma thresholds are unchanged.Change type
Pet details
aureo/008Files affected
pets/aureo/: original runtime files, six-frame 6.6-second preview and still, README, contact sheets, sanitized strict results and exception summary.catalog.json, root README, site previews/card/installer and scoped gold styling.Package checklist
Validation performed
python3 scripts/validate_catalog.py --base-ref origin/mainpython3 scripts/test_validation_exceptions.py: nine tests, including changed atlas with updated hashes, copied exception, erased findings, modified evidence and missing/corrupt package datapython3 scripts/validate_previews.py: sixteen GIF/PNG pairsThe catalogue consistency check passes with the explicit exception; this does not claim a strict atlas or all-cardinal pass. Native Áureo activation and pointer behavior were not tested. CI run 37106975153 passed on commit
2d5bd3fb43307e4a124570aafcc0c115fd3c3f08, including all nine exception tests. GitHub still requires an approving review; the normal merge was blocked by branch policy. CodeRabbit reported success but explicitly skipped review. Post-merge Pages deployment/readback remains pending.Impact
Rights
Summary by CodeRabbit