Skip to content

Bring PR-967 from main into develop - #977

Open
jdlcdl wants to merge 2 commits into
selfcustody:developfrom
jdlcdl:pr967_into_develop
Open

jdlcdl wants to merge 2 commits into
selfcustody:developfrom
jdlcdl:pr967_into_develop

Conversation

@jdlcdl

@jdlcdl jdlcdl commented Nov 15, 2026

Copy link
Copy Markdown
Member

What is this PR for?

Brings PR #967 into the develop branch, previously merged into "main" w/ urgency,
to resolve security vuln (weak ca keys).

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes, build and tested on

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

This should avoid developers and contributors to have old possible
comprimissed vversions of our package manager related dependencies
chore: updates to later python versions
@jdlcdl jdlcdl added the prioritized Prioritized focus for near-term merge label Nov 15, 2026
@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.60%. Comparing base (9092846) to head (5fa3ff9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #977   +/-   ##
========================================
  Coverage    97.60%   97.60%           
========================================
  Files           84       84           
  Lines        11001    11001           
========================================
  Hits         10738    10738           
  Misses         263      263           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odudex odudex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, and in line with Jeff instructed, all PRs that are directly merged to main, like hotfixes or doc updates, should be merged to develop as well ASAP. No need to do a dedicated PR.

@jdlcdl

jdlcdl commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

No need to do a dedicated PR.

This pr is because I had to resolve some conflicts, and so others could verify how I resolved.

@joaozinhom joaozinhom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5fa3ff9

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prioritized Prioritized focus for near-term merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants