Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #959 +/- ##
========================================
Coverage 97.60% 97.60%
========================================
Files 84 84
Lines 10994 10994
========================================
Hits 10731 10731
Misses 263 263 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8c21cac to
8981b20
Compare
|
i can see old layout still described elsewhere:
|
87d46de to
4f54c70
Compare
|
Thanks tanveer. Reopening this PR so that it makes next release.
|
|
|
||
| Alternatively, the *GPG signature file* `SHA256SUMS.asc` can be verified for Krux contributors -- if they have also signed a pre-built release: | ||
| ```bash | ||
| gpg --verify SHA256SUMS.asc SHA256SUMS |
There was a problem hiding this comment.
this is what i got while testing.
~/verify959 ❯ gpg --verify SHA256SUMS.asc SHA256SUMS
gpg: keybox '/home/sahil/verify959/gnupg/pubring.kbx' created
gpg: Signature made Sun 13 Sep 2026 03:01:51 AM IST
gpg: using EDDSA key 6DC76DC81B5C35D7F432712945D7F41053AF05F3
gpg: Can't check signature: No public key
[ble: exit 2]
should we add your key here? or let the user find out? wdyt @jdlcdl ?
| gpg --verify SHA256SUMS.asc SHA256SUMS | |
| # one time: import the maintainer key (jdlcdl) | |
| curl -sL https://github.com/jdlcdl.gpg | gpg --import | |
| gpg --verify SHA256SUMS.asc SHA256SUMS |
There was a problem hiding this comment.
I would prefer that if they want to find my sig, they don't follow a link they saw, that they reach it by searching themselves... maybe also for next maintatiner too (so inidividual is not in docs... it will be in release notes).
What is this PR for?
Docs never got updated prior to last release for "how-to verify release v26.09.0".
This pr brings "develop" up to date with how I expect future releases to be verified (similar to latest). Targeting "develop" because the ATTESTATION.txt asset included in last release explains the same.
re: notTanveer's feedback:
zip, SHA256SUMS file, and all DER signature files -- so that it can be run interactively and/or restarted. I wasn't aware of this script for release v26.09.0. I'd added CHANGELOG.md and SHA256SUMS as described in the release attestation asset... and this is where I would have needed to be able to append to the release interactively.TODO:
[ ] Krux docs that explain krux-installer to be updated (no download or verification sections since releases are embedded in krux-installer).
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?