Skip to content

OnDelay-release 26.09.0 (reviewed and ready) - #948

Merged
jdlcdl merged 34 commits into
selfcustody:mainfrom
jdlcdl:release-26.09.0
Oct 2, 2026
Merged

jdlcdl merged 34 commits into
selfcustody:mainfrom
jdlcdl:release-26.09.0

Conversation

@jdlcdl

@jdlcdl jdlcdl commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

What is this PR for?

Release has been delayed.

All previously proposed+reviewed+ACKed+approved PRs merged into krux "develop", since release 26.08.0 will be merged into "main" for release 26.09.0.

...plus: unseen chores:

  • bump version/docs/filenames to release 26.09.0. See commit ea10075.
  • update glyphs in MaixPy across all projects: 50 added, 4 removed. See MaixPy pr59 now in its "develop" branch.
  • changelog
  • manually cherry-picked qlrd's PR-949 which increases test-coverage for current release.
  • manually cherry-picked qlrd's PR-17 (my fork) which includes ktool-* flashers in reproducibility.py

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes, build and tested on (on Amigo, minimal on yahboom_devkit)

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

odudex and others added 28 commits August 8, 2026 20:14
Shown on the About page and, until acknowledged for the running version, before the application can be used. The acknowledged version is stored on flash, so a firmware update shows it again.
The disclaimer shown on the device is now also in the README and in the getting started page. Wording that might resemble marketing was removed.
Although space is limited, the addition of the term, coherent with documentation, help inform those who don't read it.

Split the label into a fixed "Estimated entropy:" prefix, drawn once, and a status line with Good, Poor! or Insufficient!, redrawn on change.

Reserve room for the extra line: crop the camera preview where it reached the last text line, and move the flash filling progress bar up.
…om camera

Camera frames are stored unscrambled, so a flash dump can reconstruct them for verification. Adds a privacy warning to the tamper detection docs and a call to
read the documentation at the start of the TC Code setup flow.
…tions

TC-code - warn about privacy when filling flash with entropy from camera
…-context

feat: show units and ranges for numeric settings
…emonic-loading

feat: make mnemonic loading format-first
pulling diverged main into develop prior to release
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (1e7216b) to head (89cb71f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
- Coverage   97.79%   97.59%   -0.20%     
==========================================
  Files          84       84              
  Lines       12043    10977    -1066     
==========================================
- Hits        11777    10713    -1064     
+ Misses        266      264       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Reviewed with:

git fetch pull/948/head && git checkout FETCH_HEAD
git submodule update --recursive
uv sync --frozen
uv run poe pre-commit

And manual lecture from memory (since reviewed some). I will do more lecture and manual tests and LYN.

As relative note for follow-up: made a patch for uncovered line on #949 if agrees.

Comment thread mkdocs.yml Outdated
latest_installer_win: krux_installer_v0.0.24_Setup.exe
latest_installer_mac_arm: krux_installer_0.0.24_arm64.dmg
latest_installer_sha: krux-installer.SHA256.txt
latest_installer_sig: krux-installer.SHA256.txt.sig

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used .asc as historical usage on last release. Should we provide both or just sig ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have missed something.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem to me put both or sig, just asking what you think is better (historically on krux, is sig, but the default on many projects is asc, so i'm really in doubt about that)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've corrected the shasums filenames to include the version (that I had missed too), and sig now has ascii-armor extension.

@odudex

odudex commented Sep 4, 2026

Copy link
Copy Markdown
Member

tACK at 7894669

@qlrd qlrd left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 7894669

@joaozinhom joaozinhom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7894669

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tACK 28b71bc

@qlrd

qlrd commented Sep 6, 2026

Copy link
Copy Markdown
Member

Opended jdlcdl#16 to cover the lines for codecov

…_lines

This commit add a `test_init_embed_fire` and a
`test_render_image_with_extra_bottom_line` for region cut in
`render_image`.

Instead of adding boards to the `multiple_devices` fixture, which would
grow every parametrized test time, i propose that the `"dock"` branch of
the render tests would come a shared config on some display tests, so it
could be an `else` branch for other devices (yahboom, wonder_mv,
wonder_k share some default values, like region and font size, so they
assert same values). They are being silently skipped while being called
anyways, so this `else` branch is just another test without significant
time increase.
@jdlcdl

jdlcdl commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Opended jdlcdl#16 to cover the lines for codecov

since it doesn't change code, yet fills-in test-coverage for current release w/o altering build reproducibility, I've cherry-picked your commit in PR#949 into this release branch. Thank you again for raising the bar.

@qlrd

qlrd commented Sep 6, 2026

Copy link
Copy Markdown
Member

Opended jdlcdl#16 to cover the lines for codecov

since it doesn't change code, yet fills-in test-coverage for current release w/o altering build reproducibility, I've cherry-picked your commit in PR#949 into this release branch. Thank you again for raising the bar.

always for team and community!

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that came to mind if we could apply (or in a follow-up the proposed refactors on imports did on #930) cc @joaozinhom

@tadeubas

tadeubas commented Sep 6, 2026

Copy link
Copy Markdown
Member

ACK, code review shared on devs Telegram group

@joaozinhom joaozinhom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 4899ee5

@jdlcdl
jdlcdl marked this pull request as ready for review September 8, 2026 20:42

@joaozinhom joaozinhom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 3b33b83

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tACK 3b33b83. Tested commit by commit, and a last special one on last commit. formats and lints broken between, but since some commits fix others, no issues on my point of view.

qlrd and others added 2 commits September 12, 2026 20:49
This commit add an extended hash check for developers while verifying
hashes of both firmware binaries as well ktool binaries.

@qlrd qlrd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tACK 89cb71f

@joaozinhom

Copy link
Copy Markdown
Member

re-ACK 89cb71f

@jdlcdl jdlcdl changed the title Proposing release 26.09.0 Proposing release 26.09.0 (release cancelled: merge to "develop") Sep 15, 2026
@jdlcdl
jdlcdl changed the base branch from main to develop September 15, 2026 10:38
@jdlcdl jdlcdl changed the title Proposing release 26.09.0 (release cancelled: merge to "develop") Proposing release 26.09.0 (no-release: merge to "develop") Sep 15, 2026
@jdlcdl jdlcdl changed the title Proposing release 26.09.0 (no-release: merge to "develop") Non-release 26.09.0 (reviewed: merge to "develop") Sep 15, 2026
@jdlcdl
jdlcdl changed the base branch from develop to main September 16, 2026 15:44
@jdlcdl jdlcdl changed the title Non-release 26.09.0 (reviewed: merge to "develop") OnDelay-release 26.09.0 (reviewed and ready) Sep 16, 2026
@jdlcdl
jdlcdl merged commit 2b20e33 into selfcustody:main Oct 2, 2026
12 checks passed
@jdlcdl

jdlcdl commented Oct 2, 2026 •

Copy link
Copy Markdown
Member Author

This pr was merged by me via "rebase-and-merge", foolishly, destroying all of the commit hashes that had been ACKed previously in closed PRs (merged to develop).

I have compared the current state of "main" at 2b20e33 against the last commit-head of this pr-branch 89cb71f to confirm no differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants