refactor: extract inline handlers from registerActivityRoutes()#773
Merged
Merged
Conversation
The 673-line registerActivityRoutes() function had all route handlers defined inline. Each handler is now a standalone named function, reducing the registration function to ~30 lines and making individual handlers independently readable and navigable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerActivityRoutes()function inapps/server/src/routes/activity.tsinto standalone named functionsregisterActivityRoutes()is now ~30 lines — a clean route registration table that delegates to named handlershandleHeatmap,handleStats,handleDailyStatus, etc.) is independently readable and navigableWhy this is tech debt
The single monolithic function made it hard to navigate to a specific route's implementation, understand its scope, or review changes to one route without scrolling past all the others. Named functions also show up in IDE outlines and stack traces.
What's next
Next debt-collector run will tackle extracting handler functions from
createMcpHandlers()inapps/server/src/server/mcp-handlers.ts(same pattern — inline handlers in a single 560-line function).🤖 Generated with Claude Code