Fix extractHunkAroundLines bug for top-of-file hunks, add 19 tests#767
Merged
Merged
Conversation
The `newLineNum === 0` guard conflated "before any hunk header" with "hunk starting at +1", silently dropping all lines from top-of-file hunks. Replaced with an `insideHunk` boolean flag. Extracted the function to shared/lib/extract-hunk.ts for testability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractHunkAroundLinesusednewLineNum === 0as a guard to skip lines before the first hunk header, but this also blocked all lines in hunks starting at+1(top of file). Replaced with aninsideHunkboolean flag.reviews.tstoshared/lib/extract-hunk.tsfor testability.Test plan
pnpm run checkpassespnpm run testpasses (2386 server + 195 web)pnpm run test:e2epasses (168 passed, 12 skipped terminal-live)vitest run test/extract-hunk.test.ts— 19/19 pass🤖 Generated with Claude Code