Skip to content

fix(web): remove unnecessary double type cast in unified-diff-view #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
selfcontained merged 1 commit into from
Jul 12, 2026
Merged

fix(web): remove unnecessary double type cast in unified-diff-view #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/web/src/components/app/unified-diff-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
return keys;
}

export function findLastChangeKeyInRange(

Check warning on line 174 in apps/web/src/components/app/unified-diff-view.tsx

View workflow job for this annotation

GitHub Actions / ci 

Fast refresh only works when a file only exports components. Use a new file to share constants or functions between components
hunks: HunkData[],
startLine: number,
endLine: number
Expand Down Expand Up @@ -264,9 +264,7 @@
const ln = getNewLineNumber(change);
if (ln === null) return;

const mouseEvent = e as unknown as MouseEvent;

if (mouseEvent.shiftKey && lineSelection) {
if (e.shiftKey && lineSelection) {
const start = Math.min(lineSelection.anchorLine, ln);
const end = Math.max(lineSelection.anchorLine, ln);
onLineSelection({
Expand Down
Loading