Repository navigation
fix(search_library): match a query whose words span fields - #415
Merged
Merged
Conversation
The whole query had to appear inside one field, so "Inferno Boards of Canada" found nothing on a library holding the album. A multi-word query now also matches when every word appears in some field; a phrase in one field still matches as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_libraryrequired the whole query inside one field (ILIKE '%query%'on title, artist, album or genre). An MCP host naturally asks for " ", so "Inferno Boards of Canada" returned nothing on the NAS library, which holds all 18 tracks of that album. Found on 2026-10-25; "Evaporator Nathan Fake" failed the same way.tests/test_search_library_words.pyruns against the real test database: album+artist, either word order, a single phrase, and a non-matching word. The two spanning tests fail against the previous code.Full backend suite: 2417 passed.
The 2-per-artist diversity cap, which hid Inferno when searching the artist alone, is unchanged;
filter_tracks(artist=…)remains the tool for that.🤖 Generated with Claude Code