Fix: Ask AI buttons + Checklist Component#529
Conversation
|
Regarding the other things in the gdoc that are not assessed here:
|
frameworks-volunteer
left a comment
There was a problem hiding this comment.
Model: z-ai/glm-5.2 Reasoning: medium Provider: openrouter
Security + QA review of PR #529 (Fix: Ask AI buttons + Checklist Component).
3 commits, 5 files changed:
- components/checklist/Checklist.tsx -- Simplifies checked-state toggling. Removes DOM-wrapping approach in favor of toggling is-checked directly on li. Extracts label text via textContent concatenation. Cleaner, avoids DOM mutation.
- components/checklist/Checklist.css -- Moves strikethrough/muted to li.is-checked, resets on nested ul/ol children. Prevents cascade into sub-items.
- functions/_middleware.ts -- New Cloudflare Pages middleware. Rewrites .md requests (excluding /assets/md/) to serve from /assets/md/ path.
- package.json -- Bumps vocs 2.0.10 -> 2.1.10, waku 1.0.0-beta.1 -> 1.0.0-beta.3
- pnpm-lock.yaml -- Lock file update.
Security: No hardcoded secrets. Middleware uses url.pathname via new URL() -- no path injection. ASSETS.fetch() scoped to Cloudflare static binding. No eval/innerHTML/dangerouslySetInnerHTML.
QA: Changes align with PR title. CSS reset on nested lists correct. slugify unchanged -- localStorage keys stable. HTMLOListElement check added (was missing). No debug content or TODOs.
Verdict: Approve. No security concerns. Code quality improved -- DOM mutation replaced with simpler class-toggle. Middleware minimal and correct.
(Note: This review was originally analyzed by the relay on 2026-06-25 10:31 but could not be posted due to expired PAT. PAT has been regenerated. Posting now.)
This PR assess the issues related to vocs v2 migration:
Copy page for AIandView as Markdownwere both serving 404.Copy page for AIwas attaching the sitemap.xml content on top of the page's content.How everything was fixed:
_middleware.ts) that moves the markdown files where vocs expects them to be to serve them. I also opened an issue on vocs repo as this should be fixed by them (when they will i will remove the function)Thanks @DicksonWu654 for the time put in collecting these :)
Preview Deployment: https://chore-v2-feedback.frameworks-573.pages.dev/