Repository navigation
Mappers dialog: describe each mapper type, show per-mapper details - #63
Open
mogglemoss wants to merge 1 commit into
Open
mogglemoss wants to merge 1 commit into
mogglemoss wants to merge 1 commit into
Conversation
Adding a mapper opened a bare dropdown of type names, so a first-time user picking between "Tripwire" and "Eve Scout" had nothing to go on — in particular that one needs an account on a Tripwire server and the other needs nothing at all. - Add opens a small picker listing each type with a one-line description of what it is and what it needs. Descriptions wrap rather than clip, since how much fits on a line depends on the platform font. - The table gains a Details column summarizing each config (Tripwire: the account user, or "no account set"; Eve Scout: "public"). It never shows a password or token; a test pins that. - The table reads as a config list rather than a spreadsheet: no painted grid, alternating row colors, and no row-number gutter. MAPPER_TYPE_DESCRIPTIONS sits beside MAPPER_TYPE_LABELS, so a new mapper type adds one line to each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small usability pass on the Mappers dialog: adding a mapper now shows what each type is and what it needs, and the mapper table gains a Details column and reads as a list rather than a spreadsheet.
Context
Add opened a bare dropdown of type names. A first-time user choosing between "Tripwire" and "Eve Scout" had nothing to go on, in particular that one needs an account on a Tripwire server and the other needs nothing. Once configured, the table showed name, type and URL, but not whose account a Tripwire entry uses, which is the thing that tells two Tripwire instances apart.
Approach
MAPPER_TYPE_DESCRIPTIONSsits besideMAPPER_TYPE_LABELS, so a new mapper type adds one line to each.Testing
test_mappers_dialog.py: every type has a description and the picker returns the chosen type; the Details column never contains the password; the table has the new column, no grid and no row numbers.Risks
Low: UI only, no config or schema changes. If #61 (Wanderer) lands first, its type would want a description line and a Details case (its map slug). Happy to add either here or as a follow-up, whichever order you prefer.
🤖 Generated with Claude Code