fix: enhance makefiles#79
Open
logic-finder wants to merge 6 commits into
Open
Conversation
logic-finder
marked this pull request as draft
June 13, 2026 10:18
logic-finder
marked this pull request as ready for review
July 23, 2026 07:07
There was a problem hiding this comment.
Pull request overview
This PR standardizes and “enhances” the C project Makefiles to be more modular/readable (Issue #66) and tidies .gitignore entries to better match generated build artifacts.
Changes:
- Reworked multiple C Makefiles to use a common template: variables section, shared
lib/compilation, and auto-dependency generation via-MMD -MP. - Updated several
.gitignorefiles to ignore*.o/*.d(and.exein some directories) and normalized formatting.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yandere/c/.gitignore | Formatting-only tidy (blank line). |
| test/.gitignore | Generalize object ignore to *.o instead of a single object file. |
| nsy2/c/Makefile | Standardized Makefile template with lib objects + .d dependencies. |
| nsy2/c/.gitignore | Ignore binary variants plus *.o/*.d. |
| nsy/c/Makefile | Standardized Makefile template with lib objects + .d dependencies. |
| nsy/c/.gitignore | Ignore *.o/*.d while keeping .dat. |
| hhss/c/.gitignore | Formatting-only tidy (blank line). |
| hd/c/Makefile | Standardized Makefile template with lib objects + .d dependencies. |
| hd/c/.gitignore | Normalize ignores (incl. tmp) and add *.o/*.d. |
| btn/c/Makefile | Standardized Makefile template with lib objects + .d dependencies. |
| btn/c/.gitignore | Ignore *.o/*.d while keeping .dat. |
Contributor
Author
|
I pushed a commit but it hasn't appeared yet :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #66.