fix: sc.pl.paga cax handling with multiple colors - #4319
Open
AdvaitS wants to merge 2 commits into
Open
Conversation
The `cax` parameter was documented as a single axes but indexed as a sequence (`cax[icolor]`), raising `TypeError: 'Axes' object is not subscriptable` when plotting multiple colors. Accept either a single axes (for one colorbar) or a sequence of axes, and raise a clear error when a single axes is given with multiple colorbars. Fixes scverse#4318
AdvaitS
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4319 +/- ##
==========================================
+ Coverage 80.08% 80.10% +0.02%
==========================================
Files 133 133
Lines 13424 13429 +5
==========================================
+ Hits 10750 10757 +7
+ Misses 2674 2672 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sc.pl.pagadocumentedcaxas a single axes but indexed it as a sequence (cax[icolor]), raisingTypeError: 'Axes' object is not subscriptablewith multiple colors. It now accepts a single axes (for one colorbar) or a sequence of axes, and raises a clearValueErrorwhen a single axes is given with multiple colorbars.Test log