fix(engine): resolve refs with spaces in the name - #1
Merged
ptaranat merged 2 commits intoAug 27, 2026
Merged
Conversation
SPEC says spaces in names normalize to hyphens, but REF_PATTERN rejected [tavern trouble] as an unsupported expression before normalization ran. Let the pattern accept internal whitespace; lookup already normalizes. Claude-Session: https://claude.ai/code/session_01KATPWtGThR74Yseo8eWwTE
There was a problem hiding this comment.
Pull request overview
Fixes cross-table reference parsing so references containing spaces (e.g. [tavern trouble]) are accepted and can be resolved after normalization (spaces → hyphens), aligning behavior with the spec and real-world Obsidian vault usage.
Changes:
- Expand the engine’s reference expression regex to permit spaces in reference names before method suffix parsing.
- Add a regression test covering space-containing refs resolving to tables by title.
- Update READMEs to reflect the current implemented Obsidian plugin surfaces and add the web package entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates package list to describe the Obsidian plugin features and add packages/web. |
| packages/obsidian/README.md | Replaces “not implemented” text with current feature set and basic install instructions. |
| packages/engine/test/roll.test.ts | Adds a regression test verifying refs with spaces resolve correctly. |
| packages/engine/src/roll.ts | Adjusts REF_PATTERN to allow spaces in ref names prior to normalization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ptaranat
deleted the
ptaranat/db-100-perhaps-refs-with-spaces-in-the-name-fail-to-resolve
branch
August 27, 2026 23:14
ptaranat
added a commit
that referenced
this pull request
Aug 27, 2026
SPEC says spaces in names normalize to hyphens, but REF_PATTERN rejected [tavern trouble] as an unsupported expression before normalization ran. Let the pattern accept internal whitespace; lookup already normalizes. Also refreshes the readmes that still called the plugin unimplemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB-100. [tavern trouble] failed as an unsupported expression even though the spec says spaces normalize to hyphens; REF_PATTERN rejected spaces before normalization ran. Found testing the Obsidian plugin against a real vault. Also refreshes the two readmes that still called the plugin unimplemented.