Skip to content

Normalize percent-encoding of the query and params, not just the path - #85

Merged
wRAR merged 3 commits into
scrapy:masterfrom
AdrianAtZyte:query-encoding
Sep 21, 2026
Merged

wRAR merged 3 commits into
scrapy:masterfrom
AdrianAtZyte:query-encoding

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Contributor

Resolves #28

@codecov

codecov Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.85%. Comparing base (1d226f9) to head (478dc87).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   98.34%   97.85%   -0.50%     
==========================================
  Files           5        5              
  Lines         423      419       -4     
  Branches       88       85       -3     
==========================================
- Hits          416      410       -6     
- Misses          4        5       +1     
- Partials        3        4       +1     
Files with missing lines Coverage Δ
src/protego/_utils.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review August 7, 2026 15:17
@codspeed

codspeed Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing AdrianAtZyte:query-encoding (478dc87) with master (1d226f9)

Open in CodSpeed

@wRAR
wRAR merged commit f23cee4 into scrapy:master Sep 21, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-encoding of URL queries causing Regex robots.txt rule matches to be missed

2 participants