Repository navigation
fix: SCO-214 skip the product catalog step for reps in onboarding - #400
Merged
Merged
Conversation
The product import writes into the org's own brand catalog, which only a brand org has, so every rep upload or manual entry on that step failed. Reps now skip it like the address and payment steps, and the rep Import subtitle no longer lists products. SCO-214 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
productstoREP_SKIPPED_SUBSin/onboarding, and filters the rep Import phase through it (that branch previously returned every base sub unfiltered).Why
The product import needs
selfBrandId, which the onboarding loader only resolves for brand orgs. Every rep upload or manual entry on the "Add your product catalog" step failed with "Product imports need a brand catalog, and that's only set up for brand organizations right now."Resume
The saved cursor is clamped and products sat before orders, so a rep saved anywhere in Import resumes on the right step. One cosmetic edge: a rep who had already skipped the products step will see Orders marked skipped in the completion summary, because sub-state keys are index-based.
Verification
bun run lintpassesbun run checkpasses (0 errors)bun run test:runpasses apart from the 10 known localrecent-searchesfailures (Node v26 localStorage), which pass in CITest plan
Closes SCO-214
🤖 Generated with Claude Code