Skip to content

chore: SCO-211 onboarding copy pass against brand voice - #396

Merged
scottcarlton merged 2 commits into
devfrom
chore/sco-211-onboarding-copy
Oct 29, 2026
Merged

scottcarlton merged 2 commits into
devfrom
chore/sco-211-onboarding-copy

Conversation

@scottcarlton

Copy link
Copy Markdown
Owner

Summary

  • Rewrote every user-facing string in /onboarding against section 1.5 of the brand guidelines: short declarative sentences, one assistant voice ("I", no more I/we mix), no em dashes in copy, verify lines, or errors.
  • Org type descriptions lead with what each type does in wholesale.
  • Drop-zone hints say what the file needs ("A CSV with one account per row.") instead of "I'll get to work on it."
  • Greeting subtitle no longer promises a catalog, which reps and retailers never build here.
  • Removed the stale header comment (mock-driven phases) and the P2 org-type matrix comment, since buildPhases() implements it.

Why

Onboarding copy was still marked provisional. This was the last open item split out of SCO-45.

Role-aware check

  • Brand: sees every phase; copy reads right.
  • Rep: brands step and rep subtitles read right.
  • Retailer: stops after General Information (create-retailer redirects to /dashboard), so only that phase's copy reaches them.

Found but out of scope (phase structure, not copy):

  • Reps get the "Add your product catalog" step, but product import is brand-org only, so any rep upload there errors (NO_CATALOG_MSG).
  • Retailers see Import, Settings, and Connections on the roadmap but never reach them.

Verification

  • bun run lint passes
  • bun run check passes (0 errors)
  • bun run test:run: 2030 pass, 10 fail in src/lib/stores/recent-searches.test.ts. Pre-existing and local-only: they fail identically on clean dev because Node v26 exposes an experimental global localStorage that shadows jsdom's. Untouched by this PR.
  • Not exercised in the browser: needs a fresh user with no organization.

Test plan

  • Sign up as a new user, pick Brand, walk every phase and read each question, hint, and completion line.
  • Repeat as Independent Sales Rep (brands step first, no Settings phase).
  • Repeat as Retailer through General Information.

Closes SCO-211

🤖 Generated with Claude Code

Minillama and others added 2 commits October 29, 2026 15:00
Rewrites every onboarding string against section 1.5 of the brand
guidelines: short declarative sentences, one voice (the assistant speaks
as "I"), no em dashes, and drop-zone hints that say what the file needs
instead of "I'll get to work on it". Org type descriptions now lead with
what each type does in wholesale. The greeting subtitle no longer promises
a catalog, which reps and retailers never build here.

Removes the stale comments about mock-driven phases and the P2 org-type
matrix, since buildPhases() implements it.

SCO-211

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SCO-211

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadline Ready Ready Preview Oct 29, 2026 9:18pm UTC

@scottcarlton
scottcarlton merged commit 3a6426c into dev Oct 29, 2026
8 checks passed
@scottcarlton
scottcarlton deleted the chore/sco-211-onboarding-copy branch October 29, 2026 21:20

This branch was successfully deployed

1 active deployment
Preview — 754dfdca Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant