Repository navigation
chore: SCO-211 onboarding copy pass against brand voice - #396
Merged
Merged
Conversation
Rewrites every onboarding string against section 1.5 of the brand guidelines: short declarative sentences, one voice (the assistant speaks as "I"), no em dashes, and drop-zone hints that say what the file needs instead of "I'll get to work on it". Org type descriptions now lead with what each type does in wholesale. The greeting subtitle no longer promises a catalog, which reps and retailers never build here. Removes the stale comments about mock-driven phases and the P2 org-type matrix, since buildPhases() implements it. SCO-211 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SCO-211 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/onboardingagainst section 1.5 of the brand guidelines: short declarative sentences, one assistant voice ("I", no more I/we mix), no em dashes in copy, verify lines, or errors.buildPhases()implements it.Why
Onboarding copy was still marked provisional. This was the last open item split out of SCO-45.
Role-aware check
create-retailerredirects to/dashboard), so only that phase's copy reaches them.Found but out of scope (phase structure, not copy):
NO_CATALOG_MSG).Verification
bun run lintpassesbun run checkpasses (0 errors)bun run test:run: 2030 pass, 10 fail insrc/lib/stores/recent-searches.test.ts. Pre-existing and local-only: they fail identically on cleandevbecause Node v26 exposes an experimental globallocalStoragethat shadows jsdom's. Untouched by this PR.Test plan
Closes SCO-211
🤖 Generated with Claude Code