Remove plotly backend#571
Draft
nvaytet wants to merge 4 commits into
Draft
Conversation
Member
How relevant is this really? Can we commit to matplotlib fully and simplify the code? |
Member
Author
That is something we should maybe think about. I guess it could simplify quite a bunch? We should still keep some clean separation between 2d and 3d plots (where we still want to use pythreejs), but otherwise I'm guessing matplotlib will live as long as python lives? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
plotlybackend, activated viapp.backends['2d'] = 'plotly'is basically unused.It only has limited support for 1d line plots.
In addition, it is slowing down addition of new features (e.g. #514 ) and adding to maintenance burden.
We remove it for these reasons.
Moving forwards, we should be careful not to have matplotlib specifics creep in to part of the codebase which should be plotting-library-agnostic.