Repository navigation
chore: remove the shebang from setup.py - #180
Open
ARYAMANN7279 wants to merge 1 commit into
Open
ARYAMANN7279 wants to merge 1 commit into
ARYAMANN7279 wants to merge 1 commit into
Conversation
setup.py is not an executable file, and newer versions of ruff report the shebang as EXE001 (Shebang is present but file is not executable), which makes the pre-commit autoupdate fail.
Member
|
Seems fine, but why are we using setuptools here, maybe we could followup and move to something else? |
Author
|
Thanks. I don't see a reason to keep it, it is just the old layout (setup.cfg + setup.py + setuptools_scm). I can follow up with a separate PR that moves it to pyproject.toml with hatchling and hatch-vcs like the other Scikit-HEP packages, if you want that. Happy to leave this one as it is so the pre-commit.ci PR can go through. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-commit.ci autoupdate in #175 fails in the
ruffhook with:setup.pyis not an executable file and is not run directly, so the shebang line is not needed. This removes it, and the check no longer applies to it. It is the only change.I could not reproduce the error locally: ruff skips this rule when it runs under WSL, which is what I use. The failing log is the one from the Format job of #175 (ruff-pre-commit v0.17.1). With the older pinned ruff (0.15.16) the file passes before and after.