Rename header guard from _IO_H_ to _STREAM_H_ in gr/stream.h - #206
Open
hmartinez82 wants to merge 1 commit into
Open
Rename header guard from _IO_H_ to _STREAM_H_ in gr/stream.h#206hmartinez82 wants to merge 1 commit into
hmartinez82 wants to merge 1 commit into
Conversation
The Windows headers' io.h define the same header guard, at least MinGW headers do, see (https://github.com/mingw-w64/mingw-w64/blob/master/mingw-w64-headers/crt/io.h). This causes functions like `gr_openstream()` and friends to not be found while building `gr`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows headers'
io.hdefine the same header guard, at least MinGW headers do. See (https://github.com/mingw-w64/mingw-w64/blob/master/mingw-w64-headers/crt/io.h).This causes functions like
gr_openstream()and friends to not be found while buildinggr.Here's an example when building with Clang: