fix(ghost-mcp): code-aware card/table splitting (v0.1.3) - #52
Merged
Merged
Conversation
The lexical builder split on <!-- card --> and <table>...</table> literally, including inside fenced blocks and inline code. A post that documents the card syntax (writing `<!-- card -->` in prose) had its card cut at that marker. Mask fenced/inline code with NUL-delimited tokens before boundary detection, then restore verbatim, so markers/tables shown in code are left intact while real ones outside code still split. NUL can't occur in markdown, so tokens never collide with prose (e.g. "24 hex"). Bump package + plugin to 0.1.3 (lockstep) so the dev channel publishes. Claude-Session: https://claude.ai/code/session_01BfjjpBQzjignajX8sZXVam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lexical builder split on
<!-- card -->and<table>…</table>literally, even inside fenced or inline code — so a post that documents the card syntax got its card cut at the marker it was describing (and table/diagram examples in code blocks would break the same way).Fix
Mask fenced blocks and inline code with NUL-delimited tokens before boundary detection, then restore verbatim. Markers/tables shown in code are left intact; real ones outside code still split as before. NUL can't occur in markdown, so tokens never collide with prose (e.g. "24 hex").
Tests (all green, 47/47)
<!-- card -->inside inline code → one card<table>+<!-- card -->inside a fenced block → one card<table>still becomes an html card while one shown in inline code doesn'tBumps package + plugin to 0.1.3 (lockstep) so
@devpublishes.https://claude.ai/code/session_01BfjjpBQzjignajX8sZXVam