Skip to content

itx - #95

Open
yuyingrong wants to merge 12 commits into
schneebergerlab:masterfrom
yuyingrong:master
Open

itx#95
yuyingrong wants to merge 12 commits into
schneebergerlab:masterfrom
yuyingrong:master

Conversation

@yuyingrong

Copy link
Copy Markdown
Collaborator
  • Please check if the PR fulfills these requirements
  • Is the commit message clear and explains what the PR does?
  • Is the PR tested?
  • Are tests for the changes available and added (for bug fixes / features)
  • If needed, docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Implemented four itxalign modes.
    Cleaned code, removed redundancies.
    Added clarifications to files such as markers.bed.

  • What is the current behavior? (You can also link to an open issue here)
    Users can only plot homologous chromosomes in pairs without a means to visualize interchromosomal structural variations.

  • What is the new behavior (if this is a feature change)?
    Users can plot chromosomes side by side and genomes in pair to visualize interchromosomal structural variations with the new itxalign feature.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Users do not need to change the command line. However, if they wish to use the itxalign feature other than its default mode, they can do so in the base.cfg or their configuration file.

  • Other information:
    Updated read.me so it is more readable. Reordered paragraphs, paraphrased sentences, and added clarifications. (I will update Tracks & Markers section in the next update.)

Comment thread plotsr/scripts/func.py
#ax, c = pltchrbox(ax, agpdata[genome.n][chrgrps[chrs[i]][s]], centrodata[genome.n][chrgrps[chrs[i]][s]], indents[s]-offset, genome.lc, chrwidth, minl=minl)
ax, c = pltchrbox(ax, v, indents[s] - offset, genome.lc, chrwidth, maxl=chrlength, minl=minl)
elif itx:
MCHR = cfg['marginchr']

@mnshgl0110 mnshgl0110 Apr 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the margins are customisable. I dont see how they are being customised within the PR.

@mnshgl0110

Copy link
Copy Markdown
Member

I assume that the plotsr.py file would also have some changes but that file does not seem to be part of it PR.

@lrauschning

Copy link
Copy Markdown
Contributor

Hi Yuying,

is the PR still open/what exactly is being implemented? I'm currently updating plotsr a bit and merging Jonas' PR, we aim to have a new release sometime next week.
Would be a good opportunity to merge this as well if it is still current!

Cheers,
Leon

@yuyingrong

Copy link
Copy Markdown
Collaborator Author

Hi Leon,

Great that you are working on this! This PR contains some code cleaning, modifications in tutorial files, and an addition of the itx functionality, so chromosome boxes can be drawn left/middle/right/equidistantly aligned. Please let me know if there are problems.

Kind regards,
Yuying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants